Ticket #597 (closed defect: fixed)

Opened 6 months ago

Last modified 3 months ago

Missing global-rtl.css and mu-rtl.css

Reported by: selad Assigned to: donncha
Priority: normal Milestone:
Component: component1 Version:
Severity: normal Keywords:
Cc:

Description

In the Hebrew translation of wpmu we see errors in the logs that global-rtl.css and mu-rtl.php are missing. These files are not in trunk. (used r1241)

Change History

(in reply to: ↑ description ) 04/18/08 19:41:50 changed by selad

That is mu-rtl.css

Sorry.

04/18/08 19:59:29 changed by donncha

  • owner changed from somebody to donncha.
  • status changed from new to assigned.

Can you tell me where these are referenced? I just did a grep for those filenames and turned up a blank..

(follow-up: ↓ 4 ) 04/18/08 20:12:14 changed by selad

  • summary changed from Missing global-rtl.css and mu-rtl.php to Missing global-rtl.css and mu-rtl.css.

I'm not sure since I can't find the reference in the code. I see in the logs: [Fri Apr 18 20:33:24 2008] [error] [client 79.182.xxx.xxx] File does not exist: /home/xxx/public_html/wp-admin/css/mu-rtl.css [Fri Apr 18 20:33:05 2008] [error] [client 79.182.xxx.xxx] File does not exist: /home/xxx/public_html/wp-admin/css/global-rtl.css

I use $text_direction = 'rtl'; in the wp-includes/languages/he-IL.php file.

(in reply to: ↑ 3 ) 05/26/08 05:20:29 changed by selad

The global-rtl.css and mu-rtl.css are not mentioned in the code specificly but they are called via the wp_admin_css() function which checks the 'text_direction' option for 'rtl'.

07/22/08 12:09:16 changed by selad

global-rtl.css was added to wp core but mu-rtl.css is missing. It is called via the wp_admin_css function when the 'text_direction' is set to 'rtl'.

Since the mu.css deals only with the blog switcher and in with a rtl setting the switcher looks just fine, an empty mu-rtl.css file may be added just to avoid the error of a missing file in the logs.

07/22/08 12:15:46 changed by donncha

  • status changed from assigned to closed.
  • resolution set to fixed.

selad - good idea. Added an empty file called mu-rtl.css in [1394]