Ticket #462 (closed enhancement: fixed)

Opened 9 months ago

Last modified 9 months ago

Reduce the ambiguity in creating blog and users and some additional checking

Reported by: ktlee Assigned to: somebody
Priority: normal Milestone: WPMU 2.0
Component: component1 Version: 2.0
Severity: normal Keywords:
Cc:

Description

This line in wpmu-edit.php will always be true, when adding a new blog

if( is_array( $_POST['blog'] ) == true )

same apply to when creating a new user

if( is_array( $_POST['user'] ) == true )

Reduce the ambiguity in creating blog and users using site->admin with correct error message, and messages.

When creating users, make sure it's a valid mail address.

When creating blog, make sure blog address isn't empty.

Attachments

blog-user.diff (6.4 kB) - added by ktlee on 10/19/07 23:16:25.

Change History

10/19/07 23:07:57 changed by ktlee

Donncha: When creating blog using the Site Admin -> Blog.

Do you want to add an additional input box for username? This will reduce the ambiguity in error echo by the following code and it's easier for new siteadmin to understand.

WPMU use blog domain as his/her username.

$user_id = email_exists($email);
if( !$user_id ) { // I'm not sure what this check should be.
	$password = generate_random_password();
	$user_id = wpmu_create_user( $domain, $password, $email );
	if(false == $user_id) {
		wp_die( __("<p>There was an error creating the user</p>") );
	} else {
		wp_new_user_notification($user_id, $password);
	}
}

10/19/07 23:16:25 changed by ktlee

  • attachment blog-user.diff added.

10/22/07 17:47:59 changed by donncha

  • status changed from new to closed.
  • resolution set to fixed.

Thanks ktlee, applied in [1122]

I think it's better to keep the form as simple as possible and once the email is received by the new blog owner it'll be obvious what they login as. It might be good to spell this out more clearly perhaps.